Return-path: Envelope-to: miguel@ssf.com.mx Delivery-date: Wed, 06 May 2015 22:50:30 -0500 Received: from lb01-ash.bitbucket.org ([131.103.20.165]:5012 helo=lb01.bitbucket.org) by vishnu.hosting-mexico.net with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85) (envelope-from ) id 1YqCpS-000YHL-Ma for miguel@ssf.com.mx; Wed, 06 May 2015 22:50:30 -0500 Received: from app02.ash-private.bitbucket.org (app02.ash-private.bitbucket.org [172.17.10.13]) by lb01.bitbucket.org (Postfix) with ESMTP id 4D7AEA8283D for ; Thu, 7 May 2015 03:50:32 +0000 (UTC) Received: from app02.ash-private.bitbucket.org (localhost [127.0.0.1]) by app02.ash-private.bitbucket.org (Postfix) with ESMTP id 4E61D2601A4 for ; Thu, 7 May 2015 03:50:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6761295920308143537==" MIME-Version: 1.0 Subject: Re: [Bitbucket] Pull request #201: Requisicion y Detalle de requisicion (globalgassf/globalnet) From: "Ricardo Sansores" To: miguel@ssf.com.mx Date: Thu, 07 May 2015 03:50:32 -0000 Auto-Submitted: auto-generated Message-ID: References: Precedence: bulk In-Reply-To: --===============6761295920308143537== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit --- you can reply above this line --- New comment on pull request: https://bitbucket.org/globalgassf/globalnet/pull-request/201/requisicion-y-detalle-de-requisicion#comment-6707551 Ricardo Sansores said: Formatear el código, he encontrado muchos lugares en que hay espacios, saltos de línea y cosas de sobra. El IDE tiene shortcuts para formatear todo y dejarlo perfectamente. -- Unwatch this pull request to stop receiving email updates: https://bitbucket.org/globalgassf/globalnet/pull-request/201/unwatch/miguelssf/227040c70998db5fb99dd488deb32b6be69c7311/ --===============6761295920308143537== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
Ricardo Sansores commented on pull request #201: Requisicion y Detalle de requisicion
app/mx/ssf/globalgas/services/accounting/RequisitionDetailService.java
88 + public RequisitionDetail saveWithJson(JSONObject requisitionDetail, String userName, String factory) throws JSONException {
89 + Requisition requisition = new Requisition();
90 +
91 +
rsansores
Ricardo Sansores commented on pull request #201:
Requisicion y Detalle de requisicion

Formatear el código, he encontrado muchos lugares en que hay espacios, saltos de línea y cosas de sobra. El IDE tiene shortcuts para formatear todo y dejarlo perfectamente.
View this pull request or add a comment by replying to this email.
92 + if ( requisitionDetail.getString("requisition.id") == null || requisitionDetail.getString("requisition.id").isEmpty()) {
93 +
94 + requisition = createRequisition(requisition, requisitionDetail.getString("requisition.department.id"), requisitionDetail.getString("requisition.employee.id"));
Unwatch this pull request to stop receiving email updates. Bitbucket
--===============6761295920308143537==--