Return-path: Envelope-to: miguel@ssf.com.mx Delivery-date: Sun, 27 Mar 2016 15:16:51 -0600 Received: from o1678990x3.outbound-mail.sendgrid.net ([167.89.90.3]:53428) by vishnu.hosting-mexico.net with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.86_1) (envelope-from ) id 1akI3E-002gSa-PB for miguel@ssf.com.mx; Sun, 27 Mar 2016 15:16:51 -0600 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bitbucket.org; h=content-type:mime-version:subject:from:to:references:in-reply-to; s=s1; bh=FCLW1B8aA/oiglQ8/urstdYjBDk=; b=PoSrzDiGkhVGHtCVtDpFx1K MSMzkf0oSfxXdwl7UKt1UUocUZ1W86NCNHFjIrHMfUKtRbrcwZC0xQA/pI/ZWdre /+1nF8ylS3Mw7RDReePm2/y3WzO/sDCVZD1LsGMFIvuGhV9ZaTXzgGDbspJLdJir tqEF3bOJlkeXxu/hj9Wk= Received: by filter0430p1mdw1.sendgrid.net with SMTP id filter0430p1mdw1.3074.56F84D97C 2016-03-27 21:16:07.140165098 +0000 UTC Received: from celery-worker-102.ash1.bb-inf.net (mail-ash.bitbucket.org [104.192.143.195]) by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id t652u1mbT7WyV1ljYU-60w for ; Sun, 27 Mar 2016 21:16:07.099 +0000 (UTC) Received: from celery-worker-102.ash1.bb-inf.net (localhost.localdomain [127.0.0.1]) by celery-worker-102.ash1.bb-inf.net (Postfix) with ESMTP id 5A30772279 for ; Sun, 27 Mar 2016 21:16:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4228663779568776620==" MIME-Version: 1.0 Subject: Re: [Bitbucket] Pull request #112: Agregados cambios de pull 672 y 674 (globalgassf/globalnet3) From: "Alexander Garcia" To: miguel@ssf.com.mx Date: Sun, 27 Mar 2016 21:16:06 -0000 Auto-Submitted: auto-generated Message-ID: References: Precedence: bulk In-Reply-To: X-SG-EID: jcizN1ZJXGzc0OL9Q7wZ4g3GQhOSGfYMdoZYX2+1YtezmX7x3qec95EkI2ZPscVrmv1/aCHGJ/4WoD pkwn0L8V3ZeN8PlxRuZ2hPn2cxkyXMdcx7S8xo19kWFIfMcXswnjVQrHgvH+97jqWzra5pprSbqyaQ wZCnL98WsjyrQoHLM/XUSo/jHp0KDiU1L5iroqI/JzcLeHfYqq5hTCEZ2rUDAlVk9K5aquyERPxZCf s= X-Spam-Status: No, score=-0.1 X-Spam-Score: 0 X-Spam-Bar: / X-Ham-Report: Spam detection software, running on the system "vishnu.hosting-mexico.net", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see root\@localhost for details. Content preview: --- you can reply above this line --- New comment on pull request: https://bitbucket.org/globalgassf/globalnet3/pull-requests/112/agregados-cambios-de-pull-672-y-674#comment-16327646 [...] Content analysis details: (-0.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: cloudfront.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [167.89.90.3 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [167.89.90.3 listed in wl.mailspike.net] 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Spam-Flag: NO --===============4228663779568776620== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit --- you can reply above this line --- New comment on pull request: https://bitbucket.org/globalgassf/globalnet3/pull-requests/112/agregados-cambios-de-pull-672-y-674#comment-16327646 Alexander Garcia said: No estas utilizando el alias del left join con m.charge, si te fijas en el select no usas n.folio y n.total, lo que esta estaria causando es que te hace doble union, el left que tu le especificas y ademas otra union porque m.charge.folio lo reconoce como otra union. Solo cambia en el select a utilizar los alias. -- Unwatch this pull request to stop receiving email updates: https://bitbucket.org/globalgassf/globalnet3/pull-requests/112/unwatch/miguelssf/a80f4c55fdd2391fa61fe83da1cdeaadf02bbaa5/ --===============4228663779568776620== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
Alexander Garcia commented on pull request #112: Agregados cambios de pull 672 y 674
app/mx/ssf/globalgas/daos/credit/LedgerMovementDAO.java
80 80 + "m.customer.creditDays,"
81 81 + "m.customer.discount )"
82 - + " from LedgerMovement m left join m.charge n join m.invoice i "
82 + + " from LedgerMovement m left join m.charge n left join m.invoice i "
xander-ssf
Alexander Garcia commented on pull request #112:
Agregados cambios de pull 672 y 674

No estas utilizando el alias del left join con m.charge, si te fijas en el select no usas n.folio y n.total, lo que esta estaria causando es que te hace doble union, el left que tu le especificas y ademas otra union porque m.charge.folio lo reconoce como otra union. Solo cambia en el select a utilizar los alias.
View this pull request or add a comment by replying to this email.
83 83 + " where m.customer.id = :customerId "
84 84 + " and m.paymentType.id = :paymentTypeId "
85 85 + " and m.balance >=1 ")
Unwatch this pull request to stop receiving email updates. Bitbucket
--===============4228663779568776620==--